microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools
MIT License
1.48k stars 454 forks source link

fix env expansion #3997

Closed qarni closed 3 months ago

qarni commented 3 months ago

Fixes #3961 and #1841

Fix environment expansion so we don't expand unnecessary variables - don't save the process.env or parent environment to the environment field of the cache.

Don't re-expand configure presets in the associated build/test/etc presets.

Fix expansion reporting issues with reporting an invalid config preset, and changing for each loop to a traditional for loop to make sure we dont have async issues with reporting.

v-frankwang commented 2 months ago

We tried to verify this issue on CMake tools: v1.19.45, but we don't have detailed reproduction steps to reproduce it.