microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools
MIT License
1.46k stars 447 forks source link

ctrl+s not working in CMake Cache Editor (UI) #4000

Open bebuch opened 3 weeks ago

bebuch commented 3 weeks ago

Brief Issue Summary

The shortcut Ctrl+S (or whatever binding is set) does not work in the UI CMake Cache Editor.

Reproduce:

  1. Open a CMake project
  2. Press F1
  3. CMake: Configure
  4. CMake: Edit Cmake Cache UI
  5. Change anything
  6. Press Ctrl+S or Menu -> File -> Save

Nothing happens. I was expecting the document to be saved.

Only the Save button at the top of the document works.

CMake Tools Diagnostics

{
  "os": "win32",
  "vscodeVersion": "1.92.2",
  "cmtVersion": "1.18.44",
  "configurations": [
    {
      "folder": "c:\\TechnoTeam\\develop\\src\\TT_CodeBase",
      "cmakeVersion": "3.29.3",
      "configured": true,
      "generator": "Ninja Multi-Config",
      "usesPresets": true,
      "compilers": {
        "C": "C:/Program Files/Microsoft Visual Studio/2022/Professional/VC/Tools/MSVC/14.40.33807/bin/Hostx64/x64/cl.exe",
        "CXX": "C:/Program Files/Microsoft Visual Studio/2022/Professional/VC/Tools/MSVC/14.40.33807/bin/Hostx64/x64/cl.exe"
      }
    }
  ],
  "cpptoolsIntegration": {
    "isReady": true,
    "hasCodeModel": true,
    "activeBuildType": "Debug",
    "buildTypesSeen": [
      "Debug",
      "Release"
    ],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 94,
    "executablesCount": 5,
    "librariesCount": 21,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": false
    }
  ]
}

Debug Log

No response

Additional Information

Version: 1.92.2 (user setup) Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9 Date: 2024-08-14T17:29:30.058Z Electron: 30.1.2 ElectronBuildId: 9870757 Chromium: 124.0.6367.243 Node.js: 20.14.0 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.22631

Yingzi1234 commented 3 weeks ago

@gcampbell-msft @bebuch This issue can reproduced on latest version v0.19.44, you can get the details below. Thank you!

ENV

  1. VSCode version:
  2. CMake tools version:
  3. C/C++ version:

Repro steps:

  1. Open a folder
  2. Click F1 to run command "CMake: Configure"
  3. Click F1 to run command "CMake: Edit Cmake Cache UI"
  4. Change "CMAKE_BUILD_TYPE" to Release/Debug
  5. Click Ctrl+S or click File> Save

Expected result: On the output window it shows that the configuration was successful and in the bottom right corner of the page appears the “CMake options have been saved.” image

Actual result: No response from within VScode. 4000