search

microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools
MIT License
1.48k stars 454 forks source link

return expandedPreset, not preset #4008

Closed gcampbell-msft closed 2 months ago

gcampbell-msft commented 2 months ago

Small bug where we were returning the wrong variable from the expandBuildPresetVariables method.

Fixes the testing done here https://github.com/microsoft/vscode-cmake-tools/pull/3905#issuecomment-2311910578.

Also fixes #4011

Thanks @v-frankwang!

@qarni FYI.

v-frankwang commented 2 months ago

@gcampbell-msft @qarni We verified both issues on CMake Tools: v1.19.47 (pre-release) and they have been fixed:

Actual result： Issue：https://github.com/microsoft/vscode-cmake-tools/issues/2934 image

Issue：https://github.com/microsoft/vscode-cmake-tools/issues/4011 image