Fix #4056, Debugger statements in production code

microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools

MIT License

1.48k stars 455 forks source link

Fix #4056, Debugger statements in production code #4082

Closed paulober closed 1 month ago

paulober commented 2 months ago

This change addresses item #4056

This changes [[visible behavior/performance/documentation/etc.]]

The following changes are proposed:

Guard debugger; statements with checks for if the code is running in development mode (already controlled by the mode switch on webpack)

gcampbell-msft commented 1 month ago

@paulober Apologies for the delay, as I was unavailable for some time, could you please update this PR to be up-to-date with main? Then, I can re-approve and merge.

gcampbell-msft commented 1 month ago

@paulober Wow, speedy! Re-approved, once it passes tests it should merge.