search

microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools
MIT License
1.48k stars 453 forks source link

fix: re-classify configureOnOpen setting #4150

Closed rzhao271 closed 3 weeks ago

rzhao271 commented 3 weeks ago

VS Code 1.95.0 is now out, and with it comes changes to the tagging system.

This PR changes the tags of the cmake.configureOnOpen setting.

For reference, the preview tag indicates that the setting ID has been finalized and that the setting is almost stable, the onExP tag indicates that the setting can be referenced in an ExP experiment, and the experimental tag, which this PR removes, now denotes a WIP setting that could potentially be renamed or removed later. If a setting is stable and not controlled by an experiment, it does not need any of these tags.

Let me know if the tags I suggest in the diff are inaccurate.

gcampbell-msft commented 3 weeks ago

@rzhao271 We feel confident with the state of that setting, does that mean that we can simply remove the tags for that setting?

rzhao271 commented 3 weeks ago

If it's not in an A/B experiment and it's ready to go, then you can remove all tags from the setting 🏁