search

microsoft / vscode-codicons

The icon font for Visual Studio Code
https://microsoft.github.io/vscode-codicons/dist/codicon.html
Creative Commons Attribution 4.0 International
869 stars 178 forks source link

Adds filled-in variants for thumbsup and thumbsdown icons. #162

Closed drob closed 11 months ago

drob commented 1 year ago

These are handy if you want to indicate to a user that a thumbs up or thumbs down action has been registered.

Fixes #161 and #163

Screenshot 2023-02-02 at 6 59 23 PM
drob commented 1 year ago

@microsoft-github-policy-service agree company="qqbot"

daviddossett commented 11 months ago

Apologies for letting this get stale. Could you pull in the latest and resolve the conflicts? I can get this in once we're all set there.

cc @albertelo

drob commented 11 months ago

@daviddossett bumped!

Not sure if it matters that thumbsup and thumbsdown are removed from the csv. Might be because I reused the mapping value in mapping.json. I noticed a few other values were reused, e.g. wrench and wrench-subaction, but in retrospect neither of them appears in the csv either or on the display site...