Open hbons opened 10 months ago
Priorities:
dist
to Releasesmicrosoft/vscode
with codicons.ttfstretch goal: automate codicons.ts file generation in vscode repo
2️⃣ Improve mapping.json
3️⃣ Automate updating of relevant microsoft/vscode-docs
pages
4️⃣ Github Pages site to browse icons
I've completed the following:
dist/
is now in .gitignore
gh-pages.yml
to publish the website (putting back dist/)codicons.ttf
is uploaded as a build artefact for each build jobcodicon.ttf
artefact is included in ReleasesOn the vscode side I've split up the list of icons into a library and a derived list. The library is a separate file that the codicons build generates with a new script: scripts/convert-to-ts.js
. I've made sure any mixed-in aliases got moved to the derived list. vscode merges these lists at runtime, so everything works as normal, but without the conflicts.
The only missing step is to automatically create a PR to microsoft/vscode
repo when a new commit happens on main. There seems to be an authentication issue here and we probably need to flip a setting or get a token from somewhere to make it work.
The rest of the ideas above are stretch goals. Having automated PRs to VS Code is the major time saver.
@mrleemurray would love your help with this last step. :) cc @daviddossett
Separate issue for the mapping improvements: https://github.com/microsoft/vscode-codicons/issues/239
Link #232, #234, #235, #236
Right now adding/changing icons in VS Code feels like it needs too many manual steps.
Issues:
icons.ttf
causes unresolvable conflicts and blocks having multiple PRs open in progress. It should probably not be kept in the git repo being a binary file.mapping.json
icons.ttf
needs to be manually committed to the main vscode repoPossible improvements:
dist/icons.*
to the Releases page. This way we keep the repo free of conflicts and can have multiple ongoing PRs open at the same timemapping.json
. This way we can see which icon names map to the same icon, and we don't need to add numbers. This will also make the mappings much easier to edit.icons.ttf
MAGIC LEVEL:
We can ask Lee to help us with this. cc @daviddossett