microsoft / vscode-codicons

The icon font for Visual Studio Code
https://microsoft.github.io/vscode-codicons/dist/codicon.html
Creative Commons Attribution 4.0 International
865 stars 178 forks source link

Improvements to mappings and automate manual steps #196

Open hbons opened 10 months ago

hbons commented 10 months ago

Right now adding/changing icons in VS Code feels like it needs too many manual steps.

Issues:

Possible improvements:

MAGIC LEVEL:

We can ask Lee to help us with this. cc @daviddossett

hbons commented 9 months ago

Priorities:

stretch goal: automate codicons.ts file generation in vscode repo

mrleemurray commented 9 months ago
hbons commented 6 months ago

I've completed the following:

On the vscode side I've split up the list of icons into a library and a derived list. The library is a separate file that the codicons build generates with a new script: scripts/convert-to-ts.js. I've made sure any mixed-in aliases got moved to the derived list. vscode merges these lists at runtime, so everything works as normal, but without the conflicts.

The only missing step is to automatically create a PR to microsoft/vscode repo when a new commit happens on main. There seems to be an authentication issue here and we probably need to flip a setting or get a token from somewhere to make it work.

The rest of the ideas above are stretch goals. Having automated PRs to VS Code is the major time saver.

@mrleemurray would love your help with this last step. :) cc @daviddossett

hbons commented 6 months ago

Separate issue for the mapping improvements: https://github.com/microsoft/vscode-codicons/issues/239

hbons commented 6 months ago

Link #232, #234, #235, #236