Add new map-vertical and map-vertical-filled icons

microsoft / vscode-codicons

The icon font for Visual Studio Code

https://microsoft.github.io/vscode-codicons/dist/codicon.html

Creative Commons Attribution 4.0 International

893 stars 178 forks source link

Add new map-vertical and map-vertical-filled icons #241

Closed hbons closed 8 months ago

hbons commented 8 months ago

Vertical variants of the map icon: map-vertical and map-vertical-filled.

Also add fold-* mappings and map-horizontal-* mappings to the original map for consistency.

Related: #238

daviddossett commented 8 months ago

What are these for? I think the original map icon is intended for source maps or something. @connor4312 would know.

connor4312 commented 8 months ago

Source maps use the compass icon

daviddossett commented 8 months ago

Ah, my bad. Hallucinating :D

hbons commented 8 months ago

Notebooks wants it, and the diff viewer uses it to toggle unchanged lines:

I thought it would be good to have a vertical version as it matches the direction. :)

hbons commented 8 months ago

@daviddossett we might want to use GitHub style collapse/expand icons in the future:

daviddossett commented 8 months ago

That notebooks issue links to the run-in-section issue. Is that intended? Not sure how it relates to the regions toggle above. Agreed that the map icon doesn't convey the command very well though. I think something like the GH example would make more sense.

hbons commented 8 months ago

seems we have these already: