search

microsoft / vscode-commander

MIT License
8 stars 3 forks source link

Command invocation tool should not wait until the command is executed #77

Open sandy081 opened 1 month ago

sandy081 commented 1 month ago

Some command invocations are not required to be waited, for eg., if I ask to open a folder or open window with a different profile or asking to change the theme. These commands open file dialogs or new windows. They should be just invoked and commander should end.

Image

If you cancel the folder dialog when asked to open a folder, the commander is still running.

benibenj commented 1 month ago

We would have to give up awaiting the response of executing commands for this to work. We do not want to give that up so this is not possible to solve on the commander side. The only way to support this is to make a change in vscode itself.

sandy081 commented 1 month ago

We do not want to give that up

But why?

benibenj commented 1 month ago

Because there are commands which return information which the commander can use. Also, when a command fails, it allows us to catch the error and commander can recover from that, I've seen this multiple times

sandy081 commented 1 month ago

Probably we should have a timeout if a command takes ever to finish?