microsoft / vscode-copilot-release

Feedback on GitHub Copilot Chat UX in Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=GitHub.copilot-chat
Creative Commons Attribution 4.0 International
338 stars 36 forks source link

Does not see the content selection added in chat #1785

Closed marcinlentner closed 3 weeks ago

marcinlentner commented 1 month ago

Type: Bug

It seems that with some characters, especially when SVG code are involved, it breaks the context, and that makes is not be included in the chat. That creates confusion for me as user, as it can do some requests but not the other. It would be better if there was some message that full context was not included because of unsupported characters.

Extension version: 0.21.1 VS Code version: Code 1.94.1 (e10f2369d0d9614a452462f2e01cdc4aa9486296, 2024-10-05T05:44:32.189Z) OS version: Windows_NT x64 10.0.22631 Modes:

System Info |Item|Value| |---|---| |CPUs|11th Gen Intel(R) Core(TM) i7-11390H @ 3.40GHz (8 x 3418)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off| |Load (avg)|undefined| |Memory (System)|31.75GB (7.90GB free)| |Process Argv|--crash-reporter-id 43ca612b-64b3-4b3c-ab61-fdabf10e5c91| |Screen Reader|no| |VM|0%|
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805cf:30301675 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 a9j8j154:30646983 962ge761:30959799 pythongtdpath:30769146 pythonnoceb:30805159 asynctok:30898717 pythonmypyd1:30879173 2e7ec940:31000449 pythontbext0:30879054 accentitlementst:30995554 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 dsvsc021:30996838 0ee40948:31013168 a69g1124:31058053 dvdeprecation:31068756 dwnewjupyter:31046869 newcmakeconfigv2:31071590 impr_priority:31102340 nativerepl2:31139839 refactort:31108082 pythonrstrctxt:31112756 flightc:31134773 wkspc-onlycs-t:31132770 wkspc-ranged-t:31151552 cf971741:31144450 defaultse:31146405 showchatpanel:31153267 cc771715:31146322 ```
marcinlentner commented 1 month ago

`<?php

function svg_accordion_plus($class = null, $width = "24", $height = "24", $fill = "currentColor") { return "

<g>
<path d='M11 17H13V13H17V11H13V7H11V11H7V13H11V17ZM12 22C10.6167 22 9.31667 21.7373 8.1 21.212C6.88333 20.6873 5.825 19.975 4.925 19.075C4.025 18.175 3.31267 17.1167 2.788 15.9C2.26267 14.6833 2 13.3833 2 12C2 10.6167 2.26267 9.31667 2.788 8.1C3.31267 6.88333 4.025 5.825 4.925 4.925C5.825 4.025 6.88333 3.31233 8.1 2.787C9.31667 2.26233 10.6167 2 12 2C13.3833 2 14.6833 2.26233 15.9 2.787C17.1167 3.31233 18.175 4.025 19.075 4.925C19.975 5.825 20.6873 6.88333 21.212 8.1C21.7373 9.31667 22 10.6167 22 12C22 13.3833 21.7373 14.6833 21.212 15.9C20.6873 17.1167 19.975 18.175 19.075 19.075C18.175 19.975 17.1167 20.6873 15.9 21.212C14.6833 21.7373 13.3833 22 12 22ZM12 20C14.2333 20 16.125 19.225 17.675 17.675C19.225 16.125 20 14.2333 20 12C20 9.76667 19.225 7.875 17.675 6.325C16.125 4.775 14.2333 4 12 4C9.76667 4 7.875 4.775 6.325 6.325C4.775 7.875 4 9.76667 4 12C4 14.2333 4.775 16.125 6.325 17.675C7.875 19.225 9.76667 20 12 20Z' fill='{$fill}' />
</g>
</svg>";

}

function svg_accordion_minus($class = null, $width = "24", $height = "24", $fill = "currentColor") { return "

<g>
<path d='M7 13H17V11H7V13ZM12 22C10.6167 22 9.31667 21.7373 8.1 21.212C6.88333 20.6873 5.825 19.975 4.925 19.075C4.025 18.175 3.31267 17.1167 2.788 15.9C2.26267 14.6833 2 13.3833 2 12C2 10.6167 2.26267 9.31667 2.788 8.1C3.31267 6.88333 4.025 5.825 4.925 4.925C5.825 4.025 6.88333 3.31233 8.1 2.787C9.31667 2.26233 10.6167 2 12 2C13.3833 2 14.6833 2.26233 15.9 2.787C17.1167 3.31233 18.175 4.025 19.075 4.925C19.975 5.825 20.6873 6.88333 21.212 8.1C21.7373 9.31667 22 10.6167 22 12C22 13.3833 21.7373 14.6833 21.212 15.9C20.6873 17.1167 19.975 18.175 19.075 19.075C18.175 19.975 17.1167 20.6873 15.9 21.212C14.6833 21.7373 13.3833 22 12 22ZM12 20C14.2333 20 16.125 19.225 17.675 17.675C19.225 16.125 20 14.2333 20 12C20 9.76667 19.225 7.875 17.675 6.325C16.125 4.775 14.2333 4 12 4C9.76667 4 7.875 4.775 6.325 6.325C4.775 7.875 4 9.76667 4 12C4 14.2333 4.775 16.125 6.325 17.675C7.875 19.225 9.76667 20 12 20Z' fill='{$fill}' />
</g>
</svg>";

}

function svg_account_circle($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

</svg>";

}

function svg_add($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

<g mask='url(#mask0_1142_6051)'>
<path d='M11.25 18.75V12.75H5.25V11.25H11.25V5.25H12.75V11.25H18.75V12.75H12.75V18.75H11.25Z' fill='{$fill}'/>
</g>
</svg>";

}

function svg_arrow_backward($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

</svg>";

}

function svg_arrow_down_alt($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

</svg>";

}

function svg_arrow_forward($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

</svg>";

}

function svg_arrow_left_alt($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

</svg>";

}

function svg_arrow_outward($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

</svg>";

}

function svg_arrow_right_alt($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

</svg>";

}

function svg_arrow_up_alt($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

</svg>";

}

function svg_attach_file($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

<g mask='url(#mask0_1734_12413)'>
<path d='M4.42896 19.071C3.34473 17.9868 2.80261 16.6904 2.80261 15.1819C2.80261 13.6734 3.34473 12.3771 4.42896 11.2928L11.8536 3.86822C12.6314 3.0904 13.5742 2.7015 14.682 2.7015C15.7898 2.7015 16.7326 3.0904 17.5104 3.86822C18.2883 4.64604 18.6772 5.58885 18.6772 6.69665C18.6772 7.80445 18.2883 8.74726 17.5104 9.52508L10.7929 16.2426C10.2979 16.7376 9.70869 16.9851 9.02515 16.9851C8.34162 16.9851 7.75236 16.7376 7.25739 16.2426C6.76241 15.7476 6.51492 15.1584 6.51492 14.4748C6.51492 13.7913 6.76241 13.202 7.25739 12.7071L13.9749 5.98954L15.0356 7.0502L8.31805 13.7677C8.1177 13.9681 8.01776 14.2038 8.01823 14.4748C8.01776 14.7459 8.1177 14.9816 8.31805 15.1819C8.51839 15.3823 8.75433 15.4825 9.02586 15.4825C9.29645 15.4825 9.53191 15.3823 9.73226 15.1819L16.4498 8.46442C16.9447 7.96944 17.1922 7.38019 17.1922 6.69665C17.1922 6.01311 16.9447 5.42386 16.4498 4.92888C15.9548 4.43391 15.3655 4.18642 14.682 4.18642C13.9985 4.18642 13.4092 4.43391 12.9142 4.92888L5.48962 12.3535C4.7118 13.1313 4.32289 14.0741 4.32289 15.1819C4.32289 16.2897 4.7118 17.2325 5.48962 18.0104C6.26744 18.7882 7.21025 19.1771 8.31805 19.1771C9.42585 19.1771 10.3687 18.7882 11.1465 18.0104L18.5711 10.5857L19.6318 11.6464L12.2071 19.071C11.1229 20.1552 9.82654 20.6974 8.31805 20.6974C6.80955 20.6974 5.51319 20.1552 4.42896 19.071Z' fill='{$fill}'/>
</g>
</svg>";

}

function svg_calendar_today($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

</svg>";

}

function svg_caret_right($class = null, $width = "20", $height = "20", $fill = "currentColor") { return "

"; } function svg_caret_down($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_caret_up($class = null, $width = "26", $height = "26", $fill = "currentColor") { return " "; } function svg_check_small($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_check($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_check_in_circle($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_close($class = null, $width = "14", $height = "14", $fill = "currentColor") { return " "; } function svg_credit_card($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_cursor($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_home($class = null, $width = "24", $height = "24", $fill = "currentColor") { return " "; } function svg_image_icon($class = null, $width = "24", $height = "24", $fill = "currentColor") { return " "; } function svg_keyboard_arrow_down($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_keyboard_arrow_left($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_keyboard_arrow_right($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_keyboard_arrow_up($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_local_mall($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_mail_fill($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_mail($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_menu($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_search($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_vertical_align_bottom($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_download($class = null, $width = "16", $height = "16", $stroke = "currentColor") { return " "; } function svg_arrow_up_right($class = null, $width = "24", $height = "24", $stroke = "currentColor") { return " "; } function svg_phone($class = null, $width = "21", $height = "20", $stroke = "white") { return " "; } function bc_circle_chevron_right($fill = "#0059AE") { return ' '; } function bc_circle_chevron_down( $fill = "#005EB8" ) { return ' '; } function bc_circle_chevron_left( $colour = "#FFFFFF" ) { return ' '; } function bc_circle_chevron_up() { return ' '; } function bc_circle_exclamation() { return ' '; } function bc_circle_close() { return ' '; } function svg_video_icon($class = null, $width = "24", $height = "24", $fill = "currentColor") { return " "; } function bc_calendar() { return ' '; } function bc_mask() { return ' '; } function bc_car() { return ' '; } function bc_stethoscope() { return ' '; } function bc_exclamation_pink() { return ' '; } function hospital() { return ' '; } function briefcase() { return ' '; } function bc_play( $fill = "#005EB8" ) { return ''; } function bc_pause( $fill = "#005EB8" ) { return ''; } function svg_social_media_icon($string, $class = null, $width = "20", $height = "20", $fill = "currentColor") { switch ($string) { case 'twitter': return svg_brand_twitter($class, $width, $height, $fill); break; case 'instagram': return svg_brand_instagram($class, $width, $height, $fill); break; case 'facebook': return svg_brand_facebook($class, $width, $height, $fill); break; case 'linkedin': return svg_brand_linkedin($class, $width, $height, $fill); break; case 'pinterest': return svg_brand_pinterest($class, $width, $height, $fill); break; case 'youtube': return svg_brand_youtube($class, $width, $height, $fill); break; case 'tiktok': return svg_brand_tiktok($class, $width, $height, $fill); break; default: return ''; } } function svg_brand_facebook($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_brand_google($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_brand_instagram($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_brand_linkedin($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_brand_pinterest($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_brand_twitter($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_brand_youtube($class = null, $width = "20", $height = "20", $fill = "currentColor") { return " "; } function svg_brand_tiktok($class = null, $width = "20", $height = "24", $fill = "currentColor") { return " "; } function svg_download_cloud() { return ' '; }`
marcinlentner commented 1 month ago

At some point it looks like the content is cut, try to create a list of function names, each on new line, just names, it will add right up to line 200, and then it breaks and can't parse the rest.

roblourens commented 1 month ago

I don't understand what I'm looking at. What do you mean by it breaks the context,. Would a screenshot help?

vs-code-engineering[bot] commented 3 weeks ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!