search

microsoft / vscode-copilot-release

Feedback on GitHub Copilot Chat UX in Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=GitHub.copilot-chat
Creative Commons Attribution 4.0 International
310 stars 28 forks source link

"Fix this" code action is streaming responses and incorrectly fixing issues. #499

Closed shism2 closed 9 months ago

shism2 commented 10 months ago

Issue:

"Fix This" code action is streaming the changes to the code editor and incorrectly solving or fixing anything. It does not fix any issue or code any longer. I'm sure other people are seeing this. This seems like a super critical issue...

Steps to reproduce:

  1. right click on any underlined issue in vscode ide for example a python file.

When I select an issue in the code editor such as:

"Cannot access member "stop_words" for type "PDFConverter" Member "stop_words" is unknownPylancereportGeneralTypeIssues Codeium: Explain Problem

(function) stop_words: Unknown".

  1. Select "Fix This"
shism2 commented 10 months ago

This issue is really really really bad.

shism2 commented 10 months ago

The issue occurs when iterative fixing is turned on.

aiday-mar commented 10 months ago

Hey @jrieken I wonder if there is a setting to turn off streaming of responses from inline chat?

@shism2 thank you for filing the issue. Since Copilot results are non deterministic (random), could you include here a copy paste or a GIF of the code before, the issue and the incorrect code after? We will look into why the fix fails.

shism2 commented 10 months ago

@aiday-mar copilotstreaming - Made with Clipchamp_1697882257151

I know it's a short example but I hope it's enough.

jrieken commented 10 months ago

@aiday-mar Streaming is not enabled for /fix. I guess this iterative fixing or a misinterpretation

aiday-mar commented 10 months ago

Hi @shism2 the gif is very blurry. Could you add one with higher resolution? If you update to the latests copilot chat release do you still see this?

shism2 commented 10 months ago

I still see the streaming but it is streaming it correctly now.

aiday-mar commented 10 months ago

According to what @jrieken mentioned, the response should not be streamed for /fix. Are you on the the latest copilot-chat extension? If you do see streaming, could you let us know by posting a gif with a higher resolution? Thank you.

shism2 commented 10 months ago

@aiday-mar Here you go: https://clipchamp.com/watch/xVVqGsByqcc

aiday-mar commented 9 months ago

Hi could you please post the output you see under Github Copilot Chat in the output view, as well as what you would expect as a result?

shism2 commented 9 months ago

The problem is already fixed. I am sorry I haven't updated everyone.

aiday-mar commented 9 months ago

Hi @shism2 thank you for letting us know. If the problem is fixed, then I will close this issue.