search

microsoft / vscode-cosmosdb

Azure Databases extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-cosmosdb
MIT License
155 stars 68 forks source link

An extra notification pops up when executing action for "postgre" database #2168

Closed v-ruizh closed 12 months ago

v-ruizh commented 1 year ago

OS: Win10 Build Version: 20230910.1

Repro Steps:

  1. Create one PostgreSQL server in VS Code.
  2. Expand the above single server -> Expand "postgre" database -> Connect to this server.
  3. Right click "postgre" database and execute any action of below. image
  4. Check whether no extra notification pops up or not.

Expect: No extra notification pops up.

Actual: An extra notification pops up. image

More Info:

  1. This issue reproduces for both single and flexible PostgreSQL server.
  2. This issue reproduces when executing any action for "postgre" database.
  3. This issue also reproduces when executing commands for "postgre" database from "Command Palette".
JasonYeMSFT commented 1 year ago

Getting the IP is expected since we need to check for firewall settings. However, I do notice that the default get IP method is taking unexpectedly long time. I will look into that and consider removing the notification.

JasonYeMSFT commented 1 year ago

The first method we use to get IP no longer works and takes an annoyingly long time to time out. I get rid of it and suppressed the "Getting public IP" info notification. Not it shouldn't take too long to expand the nodes if the firewall rules are configured or prompt the firewall error if it's not.

v-ruizh commented 12 months ago

This issue does not reproduce on extension build 20230919.6, close it.