search

microsoft / vscode-cosmosdb

Azure Databases extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-cosmosdb
MIT License
155 stars 69 forks source link

The confirmation style is still "Button Click Confirmation" when deleting database from Cosmos DB account even though change the setting "Azure Databases: Confirmation Style" to "Word Entry Confirmation" #2439

Open v-ruizh opened 2 days ago

v-ruizh commented 2 days ago

OS: Windows 10 Build Version: 20241120.1 Regression: Not a Regression

Repro Steps:

  1. Navigate to settings page -> Change the setting "Azure Databases: Confirmation Style" to "Word Entry Confirmation".
  2. Delete one container or database from a "Cosmos DB for NoSQL" account.
  3. Check whether the confirmation style is "Word Entry Confirmation" or not.

Expect: The confirmation style is "Word Entry Confirmation", like the one when deleting database from MongoDB cluster. Image

Actual: The confirmation style is still "Button Click Confirmation". Image

More Info:

  1. This setting "Azure Databases: Confirmation Style" just can control the MongoDB cluster.
  2. It would be better to change the setting to "MongoDB Cluster: Confirmation Style" if not plan to fix this issue.
tnaum-ms commented 2 days ago

@sevoku I guess we'll try to unify here and apply the confirmation style extension-wide?

I added a new function that can display the confirmation dialog based on the settings.

sevoku commented 1 day ago

@tnaum-ms ideally we should have added this everywhere else before merging.