microsoft / vscode-cpptools

Official repository for the Microsoft C/C++ extension for VS Code.
Other
5.53k stars 1.56k forks source link

Localization Walkthrough - There is an extra parenthesis for "ordinary shell" in CHS #11088

Open michelleangela opened 1 year ago

michelleangela commented 1 year ago

Note:

ENU: image

CHS has extra parenthesis: image

CHT no extra parenthesis: image

v-ericawu commented 4 months ago

Depending on the actual linguistic context CHS version is translated correctly (parentheses are required), CHT version is translated incorrectly (should be parentheses as in the CHS context)

Expected Result: CHS: image

CHT: image

bobbrow commented 2 weeks ago

@v-ericawu it looks like this issue was never reported to the Localization team and it's unclear to me what exactly we should report. In English the parentheses don't belong there and if the parentheses should exist on CHS, there should be 3 items within them (PowerShell, Bash, Windows Command Prompt), not 2.

Also it appears that "shell" might have been translated in CHT, but not CHS.

v-ericawu commented 2 weeks ago

@bobbrow

  1. According to the Chinese language environment, the brackets in this sentence are correct in CHS: An ordinary shell only includes (PowerShell, Bash) Therefore, the actual result now is that the CHS translation is correct, while the CHT translation is incorrect. And the CHT should be expected to translate as: 備註: 若要從命令列或 VS Code 使用 MSVC,您必須從 VS 的開發人員命令提示 執行。一般殼層(例如 PowerShell、Bash)或 Windows 命令提示字元,沒有設定必要的路徑環境變數集。

Actual Result: CHS: Correct translation (including correct parenthetical placement) Image

CHT: Translation error (missing a pair of parentheses) Image

  1. The “shell” does not need to be translated in CHS but only in CHT: https://termstudio.microsoft.com/ Image
bobbrow commented 1 week ago
  1. According to the Chinese language environment, the brackets in this sentence are correct in CHS: An ordinary shell only includes (PowerShell, Bash)

This is not the intent of the original English. The original string says "ordinary shell" meaning "one that does not have the correct environment variables set" and it includes PowerShell, Bash, and the Windows Command Prompt. The environment variables are only set when running the "Developer Command Prompt for VS" or "Developer PowerShell for VS" shortcuts.

v-ericawu commented 1 week ago

@bobbrow Got it, so the actual result is incorrectly translated in CHS and correctly translated in CHT. In CHS it should be translated as follows: Remove the parentheses or there should be 3 items in the parentheses (PowerShell, Bash, Windows Command Prompt)

Remove the parentheses: 注意: 要从命令行或 VS Code 使用 MSVC,必须从 VS 的开发人员命令提示 运行。普通 shell,例如 PowerShell、Bash或 Windows 命令提示符未设置必要的路径环境变量。 There should be 3 items in the parentheses (PowerShell, Bash, Windows Command Prompt): 注意: 要从命令行或 VS Code 使用 MSVC,必须从 VS 的开发人员命令提示 运行。普通 shell (例如 PowerShell、 Bash或 Windows 命令提示符)未设置必要的路径环境变量。

bobbrow commented 1 week ago

@v-ericawu, thank you for the guidance. A new loc bug has been opened.