bobbrow
commented
8 months ago At the most basic level, that doc is oversimplified. We should update it. The strategy for resolving the system includes is documented here: https://code.visualstudio.com/docs/cpp/customize-default-settings-cpp#_system-include-pathdefines-resolution-strategies
For compile_commands.json we allow for users to specify compilerPath to pick a different compiler to query in the event that the compiler listed in compile_commands.json is not queryable.
However, if you are specifying a compiler in compilerPath and it's throwing away important options from the compiler command line that are listed in compile_commands.json, we treat that as a bug in the extension.
CookiePLMonster
sean-mcmanus
Colengms
Environment
Bug Summary and Steps to Reproduce
Bug Summary:
If both
"compilerPath"and"compileCommands"are present in"c_cpp_properties.json", the former seems to take precedence during IntelliSense analysis. This results in the command line of the file present incompile_commands.json(e.g.-mcpu) to be ignored, leading to missing defines. Removing"compilerPath"results in the command line fromcompile_commands.jsonbeing taken into the account.This behaviour goes directly against what c_cpp_properties.json reference documents:
Additionally, the intended behaviour (
compile_commands.jsonoverriding other options) was mentioned yesterday in another issue: https://github.com/microsoft/vscode-cpptools/issues/11880#issuecomment-1901003596.Defining
"compilerPath": "",works as a workaround.Observed behaviour:
"compilerPath"takes precedence over"compileCommands"for populating system/architecture specific defines.Expected behaviour:
"compileCommands"takes precedence over"compilerPath"for populating system/architecture specific defines.Configuration and Logs
c_cpp_properties.json
``` { "configurations": [ { "name": "main", "intelliSenseMode": "gcc-arm", "compilerPath": "H:/dev/flipper-zero/.ufbt/toolchain/x86_64-windows/bin/arm-none-eabi-gcc.EXE", // This causes issues "compileCommands": "${workspaceFolder}/.vscode/compile_commands.json", "configurationProvider": "ms-vscode.cpptools", "cStandard": "gnu17", "cppStandard": "c++17" } ], "version": 4 } ```Language server logs ("compilerPath" absent)
``` Querying compiler's default target using command line: "H:\dev\flipper-zero\.ufbt\toolchain\x86_64-windows\bin\arm-none-eabi-gcc.EXE" -dumpmachine Compiler returned default target value: arm-none-eabi Compiler query command line: H:\dev\flipper-zero\.ufbt\toolchain\x86_64-windows\bin\arm-none-eabi-gcc.EXE -mcpu=cortex-m4 -mfloat-abi=hard -mfpu=fpv4-sp-d16 -mthumb -Wall -Wextra -Wno-address-of-packed-member -Wredundant-decls -Wdouble-promotion -fdata-sections -ffunction-sections -fsingle-precision-constant -fno-math-errno -g -Os -mword-relocations -mlong-calls -fno-common -nostdlib -std=gnu17 -Wp,-v -E -dM -x c nul Attempting to get defaults from C compiler in compile_commands.json file: 'H:\dev\flipper-zero\.ufbt\toolchain\x86_64-windows\bin\arm-none-eabi-gcc.EXE' Querying compiler for default C++ language standard using command line: H:\dev\flipper-zero\.ufbt\toolchain\x86_64-windows\bin\arm-none-eabi-g++.EXE -x c++ -E -dM nul ```Language server logs ("compilerPath" present)
``` Querying compiler's default target using command line: "H:/dev/flipper-zero/.ufbt/toolchain/x86_64-windows/bin/arm-none-eabi-gcc.EXE" -dumpmachine Compiler returned default target value: arm-none-eabi Compiler query command line: H:/dev/flipper-zero/.ufbt/toolchain/x86_64-windows/bin/arm-none-eabi-gcc.EXE -std=c++17 -Wp,-v -E -dM -x c++ nul Attempting to get defaults from C++ compiler in "compilerPath" property: 'H:/dev/flipper-zero/.ufbt/toolchain/x86_64-windows/bin/arm-none-eabi-gcc.EXE' Compiler query command line: H:/dev/flipper-zero/.ufbt/toolchain/x86_64-windows/bin/arm-none-eabi-gcc.EXE -std=gnu17 -Wp,-v -E -dM -x c nul LSP: Message ignored due to no registered handler: $/setTrace ```Other Extensions
No response
Additional context
No response