bshoshany
commented
1 week ago Update (related to issue #12806 and PR #12813): Even though the clang-tidy version is now correctly determined, the URL to the docs still has v18.1.6 hard-coded into it. You can see it here:
So maybe the version that is determined in settings.ts should be cached and then inserted into this URL? I'm talking specifically about this function that was modified in PR #12813:
Seems like an easy enough fix, if I had time I would have just written my own PR, but this is a very busy month 😞
sean-mcmanus
Environment
Bug Summary and Steps to Reproduce
When using clang-tidy, diagnostic messages displayed in the problems pane contain helpful links to the check's documentation on llvm.org. However, the link is to a version that does not match the version of clang-tidy being used. I noticed this after upgrading LLVM to v19.1.0. This version introduced some new clang-tidy checks, such as
use-std-min-max, which did not exist in previous versions. But the link provided by the extension is:https://releases.llvm.org/18.1.6/tools/clang/tools/extra/docs/clang-tidy/checks/readability/use-std-min-max.html
This link does not work, because it links to the page for v18.1.6, which did not have this particular check. The correct link is:
https://releases.llvm.org/19.1.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability/use-std-min-max.html
Which does work. I'm not sure why it links to 18.1.6, because the bundled version is actually 18.1.8, but in any case I think the extension needs to do
clang-tidy --versionon whatever binary it's using, and then provide a link to the correct version.Configuration and Logs
Other Extensions
No response
Additional context
No response