microsoft / vscode-cpptools

Official repository for the Microsoft C/C++ extension for VS Code.
Other
5.54k stars 1.56k forks source link

Handle multiple compile commands on client side (needs native server side support) #12960

Open yiftahw opened 1 week ago

yiftahw commented 1 week ago

closes #7029

DONE:

yiftahw commented 1 week ago

@bobbrow squiggles are now handled as well. I believe most of the work on the client side is done.
let me know if you have more feedback.

please note there is a new telemetry entry and a new localized string:

message = localize("multiple.paths.should.be.separate.entries", "Multiple paths should be separate entries in an array.");
newSquiggleMetrics.MultiplePathsShouldBeSeparated++;
bobbrow commented 1 week ago

@bobbrow squiggles are now handled as well. I believe most of the work on the client side is done. let me know if you have more feedback.

Thank you very much. Would you also be able to do the changes to the Edit Configurations UI in Extension/ui/settings.* so that multiple paths can be displayed/edited in that view?

yiftahw commented 1 week ago

looking into it... putting the PR back to draft for now

yiftahw commented 1 week ago

@bobbrow updated the UI panel.
note: adding a single path in the UI will save it as an array of size 1 (similar to how includePath is handled)