Open DaanDeMeyer opened 3 years ago
FYI, @WardenGnaw might be OOF till January.
@DaanDeMeyer Are you expecting the command to be:
"mkosi" ssh 'sh -c "uname && if [ $(uname) = \"Linux\" ] ; then ps axww -o pid=,comm=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,args= ; elif [ $(uname) = \"Darwin\" ] ; then ps axww -o pid=,comm=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,args= -c; fi"'
At the moment, we only use quoteArgs for the debug adapter.
This would require a change in this code path to check for quoteArgs.
Yes, that's what I was expecting. My error turned out to be caused by something else but I figure this might be useful to have nonetheless.
Type: Debugger
Describe the bug
When running the
pickRemoteProcess
command viapipeTransport
,quoteArgs
is not applied topipeArgs
and the args are quoted regardless of the value ofquoteArgs
.To Reproduce
Produces in the error log:
Command failed: "mkosi" "ssh" 'sh -c "uname && if [ $(uname) = \"Linux\" ] ; then ps axww -o pid=,comm=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,args= ; elif [ $(uname) = \"Darwin\" ] ; then ps axww -o pid=,comm=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,args= -c; fi"'
We can see "ssh" is quoted even though quoteArgs is set to false.