microsoft / vscode-custom-data

Documentation and sample for using VS Code custom data format
MIT License
196 stars 75 forks source link

Logical properties 'block-size' and 'inline-size' have wrong schema-help-text #27

Closed Tylopilus closed 3 years ago

Tylopilus commented 3 years ago

The logical properties 'block-size' and 'inline-size' have their help-text switched around. According to the spec for a default ltr ttb layout the block-size attribute corresponds to the height attribute. For 'inline-size' it corresponds to the width attribute.

https://github.com/microsoft/vscode-custom-data/blob/454cf77c1703fa048d34367597d1a7ed09deacce/web-data/css/css-schema.xml#L1100-L1101 https://github.com/microsoft/vscode-custom-data/blob/454cf77c1703fa048d34367597d1a7ed09deacce/web-data/css/css-schema.xml#L3691-L3692

aeschli commented 3 years ago

It can be either 'height' or 'width', depending on the value of writing-mode