microsoft / vscode-custom-data

Documentation and sample for using VS Code custom data format
MIT License
188 stars 73 forks source link

Replace non-ASCII punctuation (broke syntax before) #51

Closed addiment closed 1 year ago

addiment commented 1 year ago

Certain CSS snippets were broken due to using unicode special characters, specifically the unicode-range property of the @font-face at-rule. The schema had some inconsistencies in using special characters and regular ASCII, so I replaced those instances with their respective ASCII counterparts.

While the ASCII swap on quotation marks and parenthesis is mostly preference, the unicode hyphens don't work when used in the browser, which I believe warrants the change. From the W3C CSS fonts specification:

If the next code point in text is U+002D HYPHEN-MINUS (-), consume it. Otherwise, this is an invalid \<urange>, and this algorithm must exit.

4.5. Character range: the 'unicode-range' descriptor 7.1. The \<urange> type

addiment commented 1 year ago

@microsoft-github-policy-service agree

addiment commented 1 year ago

any maintainers want to check this? @aeschli

addiment commented 1 year ago

Resolved the merge conflict (wasn't much to do), can I get another review?

addiment commented 1 year ago

Gonna mention since this might get lost in notification hell otherwise @sandy081

aeschli commented 1 year ago

Thanks @addiment!