Closed rictic closed 3 years ago
Thanks! Do you mind adding documentation
as well?
Where would I put that? Interestingly, it seems like by the time this data makes it into vscode-html-languageservice it has picked up a description along the way: https://github.com/microsoft/vscode-html-languageservice/blob/master/src/languageFacts/data/webCustomData.ts#L4380
Sorry, my bad, I realized I had https://github.com/microsoft/vscode-custom-data/issues/5 to track it. Here is where the other documentation is coming from https://github.com/microsoft/vscode-custom-data/blob/master/web-data/html/ariaSpec.json.
Here's a sample: https://github.com/microsoft/vscode-custom-data/blob/75f1c88b165860630f6d180d4f2981f34e773283/web-data/html/valueSets.json#L75-L98
I just created a PR to address the same issue. Then I looked at the existing PRs and saw there's already one open. Oops! Mine has the documentation that this one is missing.
/cc @aeschli
Closing in favor of https://github.com/microsoft/vscode-custom-data/pull/18
As of ARIA 1.1 aria-haspopup isn't just a boolean, it also has some additional allowed values:
https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup