search

microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
273 stars 79 forks source link

debugProtocol.json: `DisconnectArguments` does not define `restart` arg, but VScode sends it #113

Closed metaleap closed 6 years ago

metaleap commented 7 years ago

An oversight? Or is it not supposed to be in the public API/protocol for custom debug servers? Or is restart too new, or already deprecated? =)

metaleap commented 7 years ago

I guess I didn't at first completely grasp the "Arguments" concept pervading various areas in the protocol where args are really various non-protocol-prescribed, client-or-server-specific arbitrary things. So closing as I'm assuming "if it isn't in the protocol, it's client-specific"

weinand commented 6 years ago

All "arguments" passed to requests should be "protocol-prescribed". If they are not, then only reason is that they are experimental (and we are not yet sure whether we should promote them to become part of the protocol).

The restart arg on DisconnectArguments falls into the "experimental" category and is only used for the extension host debugging which is a built-in feature of VS Code and node-debug2. There is no need to make this official at the moment.

The other case I'm aware of is the "__restart" attribute passed to the "attach" and "launch" request which I'll add with this issue.

What other non-protocol-prescribed arguments have you found?