search

microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
273 stars 79 forks source link

Add 'processEvent' to debug protocol #124

Closed gregg-miskelly closed 7 years ago

gregg-miskelly commented 7 years ago

This defines a new 'processEvent' to resolve https://github.com/Microsoft/vscode-debugadapter-node/issues/122

msftclas commented 7 years ago

@gregg-miskelly, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

gregg-miskelly commented 7 years ago

FYI @andrewcrawley @DavidKarlas @weinand

andrewcrawley commented 7 years ago

LGTM. When would isLocalProcess be false? Every "remote" scenario I'm aware of has the machine boundary between the UI and the debug adapter, not between the DA and the debuggee.

gregg-miskelly commented 7 years ago

@andrewcrawley -- I would expect that debug adapters that are remoted themselves should probably not set this at all (unless they are aware of when they are being remoted). The one place I was expecting to use this was in vsdbg-ui since it is always local and could give the IDE which is talking to it information about if the process was local or not.

DavidKarlas commented 7 years ago

LGTM

weinand commented 7 years ago

FYI: Debug adapters cannot run remote because the DAP uses local file paths, so there is an assumption that they run side by side with the frontend/client and they have access to the workspace. It would be possible to remove this assumption (by changing the DAP), but this would be a breaking change.

weinand commented 7 years ago

@gregg-miskelly Perfect! Thanks for the PR.