microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
273 stars 79 forks source link

Breakpoint marker is deleted even though the breakpoint still exists #139

Closed DatGuyJonathan closed 7 years ago

DatGuyJonathan commented 7 years ago

When the user deletes a breakpoint from the UI, the marker is removed right away then the adapter gets a setBreakpointsRequest for that URI without that line breakpoint, so the adapter figures out the breakpoint was deleted. If the adapter fails to delete that breakpoint on the server side, my adapter sends a response that it's still a verified breakpoint. I have an adapter that needs to make a network call to create/delete a breakpoint, so it's possible a delete fails. In this scenario, the client UI says the breakpoint is deleted, but the server still has it enabled.

What's the suggested way to stop VS Code from deleting that breakpoint?

weinand commented 7 years ago

This issue was moved to Microsoft/vscode#39198