search

microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
273 stars 79 forks source link

Allow setting log file path with logger setup() #144

Closed roblourens closed 6 years ago

roblourens commented 6 years ago

Fixes #143

The real change is that instead of passing the log file path to the constructor of LoggingDebugSession, it should be passed later in setup. I don't know why I did it that way to start out with, since the log file isn't created until setup happens anyway.

This would technically be a breaking change to the logger/LoggingDebugSession, but I'm not sure whether anybody is using it. Just in case, I've patched it up to allow keeping the same API. I would prefer to clean it up, but I assume there are other breaking changes that we are sitting on that can wait until something like 2.0. Thoughts?

weinand commented 6 years ago

Thanks for the PR, that makes a lot of sense...

weinand commented 6 years ago

Yes, being backward compatible is the way to go until we start with a breaking 2.0 version.