search

microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
271 stars 77 forks source link

Can't compile against debug adapter without node typings #272

Open dbaeumer opened 2 years ago

dbaeumer commented 2 years ago

I wanted to implement a debug adapter for the web using the @vscode/debugadapter npm module but I can't compile the code with out having node typings install (which gives a wrong impression for people want to do something for the web). The reason for that are these reference /// <reference types="node" /> in the provided d.ts files.

Would it be possible to have a module that I can use without node typings. If you want I can explain how I did this for LSP.

connor4312 commented 2 years ago

It looks like we currently depend on NodeJS types for (exclusively?) readable/writable streams. We could probably swap those out for minimal interfaces within the module which NodeJS streams can be duck-typed into. If we were to make a breaking change I would suggest taking Readable/Writable streams from the Streams API, which is standard with Node.js APIs that allow conversion to and fro.

dbaeumer commented 1 year ago

I have these in LSP. They are here: https://github.com/microsoft/vscode-languageserver-node/blob/8de18faed635819dd2bc631d2c26ce4a18f7cf4a/jsonrpc/src/common/ral.ts#L9