microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
271 stars 77 forks source link

When producing types declarations, also emit the static types of the interfaces for TypeScript declarations. #284

Open ashgti opened 1 year ago

ashgti commented 1 year ago

When producing types declarations, also emit the static types of the interfaces for TypeScript declarations.

This improves type checking on the declaration.

Related to #283

connor4312 commented 1 year ago

@roblourens what are your thoughts on this? I like the change overall, but it is breaking by introducing new type constraints. Do you know if there was a process for this kind of thing previously?

roblourens commented 1 year ago

Thanks, I'm good with this now