search

microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
273 stars 79 forks source link

'origin' in SourceResponse vs Source #61

Closed roblourens closed 8 years ago

roblourens commented 8 years ago

It might make sense for the 'origin' property to be returned as part of the SourceResponse vs the Source object on a StackFrame, since the only place it's currently surfaced is when vscode requests the source from the debug adapter. Also, since the Source is used other places where the origin won't be applicable.

But if we want to show the origin in the callstack before a source request happens, it should stay on the Source.

weinand commented 8 years ago

@roblourens yes, we should have the option to show the source's origin in the callstack before a source request happens. So let's keep origin on Source.