search

microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
273 stars 79 forks source link

Allow requests to specify formatting hints. #82

Closed richardstanton closed 8 years ago

richardstanton commented 8 years ago

Add optional formatting object to allow customization on how values and stack frames are displayed.

@weinand @jacdavis @gregg-miskelly @andrewcrawley @tzwlai

msftclas commented 8 years ago

Hi @richardstanton, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Richard Stanton). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

weinand commented 8 years ago

@richardstanton before sending a PR please create an issue that explains the protocol additions and where we can discuss it.

richardstanton commented 8 years ago

@weinand I created an issue for this. Sorry, I misunderstood the process for protocol changes. https://github.com/Microsoft/vscode-debugadapter-node/issues/84

weinand commented 8 years ago

@richardstanton great, thanks a lot. In VS Code we always try to have a feature discussion before a PR is created. With this we try to avoid that a PR diverges too much from our own plans and thinking.

weinand commented 8 years ago

@richardstanton thanks for this PR!