search

microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
273 stars 79 forks source link

Add value formatting to customize set variables response #90

Closed richardstanton closed 7 years ago

richardstanton commented 7 years ago

I missed this case in #82. This specifies the format of the value in the response of set variable.

@weinand @jacdavis @gregg-miskelly @andrewcrawley @tzwlai

msftclas commented 7 years ago

Hi @richardstanton, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Richard Stanton). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

weinand commented 7 years ago

@richardstanton the title of this PR talks about a change to the "set variables response" but the actual commit modifies the SetVariableArguments. I don't think that this is the intended change, correct?

weinand commented 7 years ago

@andrewcrawley is my last comment correct?

richardstanton commented 7 years ago

This is the intended change. The format property on the request's arguments determines the value of the response.

weinand commented 7 years ago

@richardstanton aha, now I understand.