search

microsoft / vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.
Other
273 stars 79 forks source link

Support setScriptSource #91

Closed jkrems closed 7 years ago

jkrems commented 7 years ago

One of the major productivity wins of using Devtools is the ability to edit the code while the app is running. It's a bit tricky in node because of the potential node-style CommonJS wrapper but it should be possible to sync editor changes to the running node process.

weinand commented 7 years ago

The Debugger for Chrome provides this functionality already based on file watching. This proves that DAP support is not needed to implement this feature.

roblourens commented 7 years ago

Er, it could, but it doesn't yet.

roblourens commented 7 years ago

I know we talked about it awhile ago and I don't remember whether @auchenberg prototyped it.

auchenberg commented 7 years ago

I didn't as we got Webpack HMR working, which moved the responsibility outside of VS Code and enables a cleaner architecture.

On Sat, Aug 26, 2017 at 9:15 PM Rob Lourens notifications@github.com wrote:

I know we talked about it awhile ago and I don't remember whether @auchenberg https://github.com/auchenberg prototyped it.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode-debugadapter-node/issues/91#issuecomment-325156517, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKl97-pBBWiI7Sdn96_Y2-A3EeBNR__ks5scG7tgaJpZM4LOuqn .

weinand commented 7 years ago

his feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

jkrems commented 7 years ago

Would you accept an external contribution that adds an {Update,Edit,Set,Whatever}SourceRequest to the protocol?