search

microsoft / vscode-deploy-azure

VS code extension: Deploy To Azure, which helps set up CI/CD for deployment to Azure Resources.
MIT License
18 stars 19 forks source link

Consider depending on VSCode-YAML rather than directly on yaml-language-server #130

Open JPinkney opened 4 years ago

JPinkney commented 4 years ago

Hi,

from looking into your repository it looks like you use the yaml language server directly rather than relying on VSCode-YAML for the YAML support. I was wondering if there is any particular reason why you spawn up the language server yourself, rather than just using VSCode-YAML as an extension dependency and having that spawn it. If you are doing this because there are some API's missing that you need then please let me know.

The only reason I bring this up is this has been done before and it will eventually lead into multiple language servers running for a yaml file if the user has vscode-yaml and this extension installed. This can create several unintended results like duplicate completions, etc etc.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for 7 days with no activity.

gorkem commented 3 years ago

@egamma FYI

egamma commented 3 years ago

CC @fiveisprime

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 7 days with no activity.

github-actions[bot] commented 3 years ago

This issue is marked default for generating issues report.