search

microsoft / vscode-deploy-azure

VS code extension: Deploy To Azure, which helps set up CI/CD for deployment to Azure Resources.
MIT License
18 stars 19 forks source link

Adding notification post GitHubPat input #134

Closed kanika1894 closed 4 years ago

kanika1894 commented 4 years ago

Since the user isn't aware of the repo analysis call being made post the input of GitHubPat, it is likely that he will try creating a new flow using Ctrl+Shift+P which creates faulty telemetry logs. Therefore, adding additional notification to prevent such scenarios.

bishal-pdMSFT commented 4 years ago

@kanika1894 we already had notification for repo analysis. Has that regressed?

kanika1894 commented 4 years ago

@kanika1894 we already had notification for repo analysis. Has that regressed?

No, that is still there In configure class, there is a getSelectedPipeline() function which has that notification - Analyzing your repo But that comes quite late in the flow, and till there is nothing for user display. The time difference is more specially when the gitHubPat entered is incorrect.

bishal-pdMSFT commented 4 years ago

okay got it. so that notification is for local analysis.

I think we should change that notification to say "fetching templates"