search

microsoft / vscode-deploy-azure

VS code extension: Deploy To Azure, which helps set up CI/CD for deployment to Azure Resources.
MIT License
18 stars 19 forks source link

More Tolerant Conditions for Visibility Rules #205

Closed mindlessroman closed 3 years ago

mindlessroman commented 3 years ago

Visibility rules for the the task.json (ie when building a custom AzDO task) currently only allow for alphanumeric characters and spaces.

This is very limiting if you have a string on the other side of the conditional - someVariable = my_value or someVariableName != some-guid-goes-here . Proposing to include hyphens and underscores to be more inclusive and therefore more flexible for options. The left side of the operation can stay alphanumeric-and-space, but the contents on the right side should be more flexible than it currently is.

See this issue in azure-pipelines-task-lib: https://github.com/microsoft/azure-pipelines-task-lib/issues/658 Someone there requested # to be a viable character but may be something to consider later?

mindlessroman commented 3 years ago

And it seems I had a bit of a brainfart - you all just maintain the code for the extension. I hope still that this can spark a discussion, maybe who to talk to.

bishal-pdMSFT commented 3 years ago

@mindlessroman this repo is a vs code extension and not ADO tasks repo. I would suggest you to use Developer community forum to raise this issue or may be even try the tasks repo.