search

microsoft / vscode-dev-chrome-launcher

Type `code` in your browser to open GitHub repositories in vscode.dev
https://chrome.google.com/webstore/detail/vs-code/kobakmhnkfaghloikphojodjebdelppk
MIT License
13 stars 7 forks source link

Add support for Firefox preview #19

Open mirdaki opened 2 years ago

mirdaki commented 2 years ago

Addresses #16

Firefox only has preview support manifest v3 right now. To run this, follow the preview instructions

Firefox supports most the chrome.* API, so this adds checks for unsupported items

However, Firefox does not currently support service workers nor Chromium support background pages. See this for details

This means the manifest file will be incompatible with at least one browser ecosystem. Since stable Firefox doesn't support manifest v3 extensions anyway, I've just left that commented out. The other options end up with duplicated code

Happy to try another approach and will file an issue to update this when stable Firefox supports manifest v3

mirdaki commented 1 year ago

@joyceerhl the last change should make it good to go

mirdaki commented 1 year ago

Firefox now has GA support for manifest V3 extensions, so this should be revisited