search

microsoft / vscode-dev-containers

NOTE: Most of the contents of this repository have been migrated to the new devcontainers GitHub org (https://github.com/devcontainers). See https://github.com/devcontainers/template-starter and https://github.com/devcontainers/feature-starter for information on creating your own!
https://aka.ms/vscode-remote
MIT License
4.72k stars 1.4k forks source link

base.Dockerfile included in built package #1484

Open chrmarti opened 2 years ago

chrmarti commented 2 years ago

Not sure when this started, but with 0.237.0 I see the base.Dockerfile included in the package we use for Remote-Containers. E.g., with the Node.js & TypeScript template.

joshspicer commented 2 years ago

Interesting, I am unsure what could've changed 🤔

Chuxel commented 2 years ago

It looks like pagination logic got thrown off somehow. See the log snippet below from the package step in the release. There are two pages despite the fact only one is configured. I suspect this was triggered by this PR that removed the parent from java-8 since it's no longer needed. That exposed an existing bug.

@joshspicer If you tactically add the parent back, that should resolve it since that only affects build order. You can then see what might be throwing the logic off.

(*) Builds paginated as follows: [
    [
        "debian",
        "ubuntu",
        "cpp",
        "alpine",
        "codespaces-linux",
        "dotnet",
        "go",
        "java",
        "java-8",
        "php",
        "python-3",
        "python-3-anaconda",
        "python-3-miniconda",
        "rust",
        "ruby",
        "jekyll"
    ],
    [
        "javascript-node",
        "typescript-node",
        "github.com/microsoft/vscode"
    ]
]
(*) Processing page 1 of 1.

The definitions listed in page 1 have their base.Dockerfile removed, but page 2 does not.

chrmarti commented 2 years ago

Are we still using npm for creating the package? We could just add base.Dockerfile to the .npmignore.

joshspicer commented 2 years ago

@samruddhikhandale , as you're directly working with the build tool, something to keep an eye out for.

chrmarti commented 2 years ago

Opened #1494 for the .npmignore suggestion. We need to get a fix in place for the release.

chrmarti commented 2 years ago

Still an issue in 0.241.1. 🤔