search

microsoft / vscode-dev-containers

NOTE: Most of the contents of this repository have been migrated to the new devcontainers GitHub org (https://github.com/devcontainers). See https://github.com/devcontainers/template-starter and https://github.com/devcontainers/feature-starter for information on creating your own!
https://aka.ms/vscode-remote
MIT License
4.71k stars 1.4k forks source link

rust-debian.sh: fix set -e interaction with nightly rust detection #1592

Closed tomaszjonak closed 2 years ago

tomaszjonak commented 2 years ago

Currently feature(rust) in devcontainer definition fails container build unless user specifies nightly rust.

Issue was introduced in commit 10bf6f70c4f467be58dee5df8a7ff19cc598e09f https://github.com/microsoft/vscode-dev-containers/pull/1554

Lack of "nightly" in RUST_VERSION will result in nonzero return code from grep. This in turn triggers -e option set for the whole script. As a result build silently fails.

tomaszjonak commented 2 years ago

cc joshspicer

joshspicer commented 2 years ago

Thanks for this!