search

microsoft / vscode-dev-containers

NOTE: Most of the contents of this repository have been migrated to the new devcontainers GitHub org (https://github.com/devcontainers). See https://github.com/devcontainers/template-starter and https://github.com/devcontainers/feature-starter for information on creating your own!
https://aka.ms/vscode-remote
MIT License
4.72k stars 1.41k forks source link

New Python3.10 Image `0.203.6` is broken #1594

Open aguckenber-chwy opened 2 years ago

aguckenber-chwy commented 2 years ago

Steps to Reproduce:

  1. A newer dev-container image for Python3.10 seems to have been published that our container started using and the local builds all failed. We add poetry to the image via the following but when inside the container, if we do poetry install it all breaks. Also ZSH becomes buggy. Backspacing in ZSH now acts as if hitting space bar instead. Reverting the image makes everything work as expected. 
    
# =================================================================================================
# Install Poetry and Configure Poetry
RUN curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python -
ENV PATH="~/.poetry/bin:$PATH"
# We will use poetry to install global requirements since we are inside a container anyway
ENV POETRY_VIRTUALENVS_CREATE="true"
ENV POETRY_CACHE_DIR="/workspace/.devcontainer/poetry-cache"

=================================================================================================

joshspicer commented 2 years ago

@aguckenber-chwy - Do you have any of the associated logs illustrating what is not working for you? I am not familiar with this particular python tool, but I will give it a try to reproduce.

joshspicer commented 2 years ago

From https://python-poetry.org/docs/, it appears the get-poetry.py script is about to be deprecated.

Screen Shot 2022-08-23 at 1 12 02 PM

The docs now suggest using this install script piped to python3 (should be fine to pipe to python in our images though).

curl -sSL https://install.python-poetry.org | python3 -

This seems to install for me. I don't have a great example for using poetry install but will try with a further example if this new install script doesn't do it for you.

image
aguckenber-chwy commented 2 years ago

Cool that fixed poetry. I missed that thank you very much. One thing I still notice with this new image though is ZSH appears to be messed up. Backspaces appears to be spaces (I am assuming its just special characters). This is my using backspace (not space) in the container.

https://user-images.githubusercontent.com/102978950/186226272-2455b8be-ed42-474d-a229-49a52560fe40.mov