search

microsoft / vscode-dev-containers

NOTE: Most of the contents of this repository have been migrated to the new devcontainers GitHub org (https://github.com/devcontainers). See https://github.com/devcontainers/template-starter and https://github.com/devcontainers/feature-starter for information on creating your own!
https://aka.ms/vscode-remote
MIT License
4.7k stars 1.41k forks source link

Updates community templates/definitions #1659

Closed samruddhikhandale closed 1 year ago

samruddhikhandale commented 1 year ago

Updates community templates to follow the spec.

All other templates are now hosted from the https://github.com/devcontainers/templates repository.

eitsupi commented 1 year ago

Hello. I was expecting this repository to be archived and was preparing to move the R definition to @rocker-org. (So I am surprised by this PR)

Should I continue to keep the R definition on this repository? Or should we create and maintain a new template repository in @rocker-org and deprecate the R definitions here? My only point of contention is whether or not the template can be easily called up on the VSCode UI, and I will continue to maintain it in either case.

Thanks.

samruddhikhandale commented 1 year ago

Hi @eitsupi, Apologies for the confusion. We are hosting the community templates in this repository for backward compatibility until the corresponding authors moves them to their own repositories. 😄

We will soon make an outreach and announcement with more details. // cc @bamurtaugh

My only point of contention is whether or not the template can be easily called up on the VSCode UI

See https://containers.dev/collections for instructions on how the Templates would show up in the UX.

eitsupi commented 1 year ago

Thank you for your explanation. It makes sense to me. And thank you for doing so much work so that this does not have to be an abrupt transition!

eitsupi commented 1 year ago

Sorry to keep asking this question, but would you be able to provide us a "template of templates"? In other words, should I start building a template repository now based on https://github.com/devcontainers/templates? Or should I wait for a template of devcontainer templates like https://github.com/devcontainers/feature-template?

bamurtaugh commented 1 year ago

Thanks @eitsupi, this is a good topic!

We've opened https://github.com/devcontainers/spec/issues/116 to track creating such a repo. However, we do hope the content in https://github.com/devcontainers/templates and the spec (templates, templates distribution) is sufficient to start self-hosting your templates now, so please feel free to start creating a repo, and you can always let us know if you have any questions or feedback.

eitsupi commented 1 year ago

Thank you for the clarification! Yes, no doubt your repositories provide me with enough information.

Will work on that as soon as possible.

cc @cboettig