search

microsoft / vscode-docker-extensibility

Docker for Visual Studio Code: Extensibility Model
MIT License
10 stars 4 forks source link

Asynchronously fetch `createdAt` details #191

Closed bwateratmsft closed 12 months ago

bwateratmsft commented 1 year ago

This is incomplete. Still need to stop using .map within getTags / getRepositories in Github and Generic providers

alexyaang commented 12 months ago

would we be able to use map here? https://github.com/microsoft/vscode-docker-extensibility/blob/bmw/registries-final/packages/vscode-docker-registries/src/clients/GitHub/GitHubRegistryDataProvider.ts#L68

bwateratmsft commented 12 months ago

would we be able to use map here? https://github.com/microsoft/vscode-docker-extensibility/blob/bmw/registries-final/packages/vscode-docker-registries/src/clients/GitHub/GitHubRegistryDataProvider.ts#L68

Yes, that is a place we can use it. We can't use it to recreate objects but we can use it to create them for the first time.

alexyaang commented 12 months ago

would we be able to use map here? https://github.com/microsoft/vscode-docker-extensibility/blob/bmw/registries-final/packages/vscode-docker-registries/src/clients/GitHub/GitHubRegistryDataProvider.ts#L68

Yes, that is a place we can use it. We can't use it to recreate objects but we can use it to create them for the first time.

gotcha, I see