microsoft / vscode-docker-extensibility

Docker for Visual Studio Code: Extensibility Model
MIT License
10 stars 4 forks source link

fix: Inspect Image Manifest 404 #225

Closed MrXhh closed 7 months ago

MrXhh commented 7 months ago

1) selected image tag: Inspect Image Manifest 2) Request to http://localhost:5000/v2/xxx/manifests/xxx failed with status 404: Not Found

bwateratmsft commented 7 months ago

I was not able to reproduce the original 404 issue on any registries I tried. What registry are you using where you are seeing it? (I typically use the registry:2 image when testing a localhost registry)

MrXhh commented 7 months ago

I was not able to reproduce the original 404 issue on any registries I tried. What registry are you using where you are seeing it? (I typically use the registry:2 image when testing a localhost registry)我无法在我尝试的任何注册表上重现原始的404问题。你在哪里看到的是什么注册表?(我通常在测试本地主机注册表时使用 registry:2 镜像)

  1. start registry: docker run -d -p 5000:5000 --name registry registry:2
  2. build image: docker buildx build --platform linux/386,linux/amd64 ...
  3. selected image tag: Inspect Image Manifest
  4. Request to http://localhost:5000/v2/xxx/manifests/xxx failed with status 404: Not Found
bwateratmsft commented 7 months ago

I pushed the image inbetween step 2 and 3 but still wasn't able to reproduce the 404. I'm concerned about changing the accept header here because it affects all requests to V2 registries, not just the image manifest requests.

MrXhh commented 7 months ago

multi-platform-registry-404.zip

bwateratmsft commented 7 months ago

Thanks, I am able to reproduce now. I will try your fix.

MrXhh commented 7 months ago

@microsoft-github-policy-service agree

bwateratmsft commented 7 months ago

Looks great, thanks for the contribution @MrXhh!