search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.2k stars 513 forks source link

Move "build in ACR" command to ACA extension #3873

Open bwateratmsft opened 1 year ago

bwateratmsft commented 1 year ago

The Azure Container Apps extension is soon adding a command to build images in ACR. Using this would allow us to remove several Azure packages as dependencies, improving load time and reducing bundle size.

TODO: do we want to remove the command entirely, or leave in a soft entry point like we currently have with "Deploy to ACA"?

dbreshears commented 1 year ago

Will this require having an ACA dependency to simply deploy to ACR?

bwateratmsft commented 1 year ago

Will this require having an ACA dependency to simply deploy to ACR?

No, the only thing I'd like to move is the "Run as task in Azure" / "Build image in Azure" feature. Local build and push, along with the other ACR features (repo browser essentially) should definitely stay in the Docker extension.

dbreshears commented 1 year ago

Let's seperate this into an NPM package that ACA and other extensions can leverage

dbreshears commented 1 year ago

Moving to future as ACA still requires the Docker extension for authenticating and getting subscription/registry information.