microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.21k stars 515 forks source link

There is an extra step "Select subscription" when pushing image to ACR with only one subscription selected #4084

Closed v-ruizh closed 1 year ago

v-ruizh commented 1 year ago

OS: Win 10 Build Version: 20230922.1 Regression: Previous Release

Repro Steps:

  1. Connect Azure registry and make sure only one subscription is list.
  2. Navigate to Image view -> Right click one image and select "Push..." action -> Select "Azure".
  3. Check whether the next step is "Select registry" or not.

Expect: The next step is "Select registry".

Actual: The next step is "Select subscription".

More Info: This issue does not reproduce on the current released Docker extension v1.26.1.

alexyaang commented 1 year ago

This is expected behavior due to the new registry experience we created along with the registries revamp. I'll go ahead and close this one if it's okay with @bwateratmsft

bwateratmsft commented 1 year ago

I'm OK with it. It's not a trivial amount of work to change but adds such a little burden to users.

alexyaang commented 1 year ago

yeah i agree

bwateratmsft commented 1 year ago

We'll close this since it's a fair bit of work to change but has little impact. If we hear from users that it's annoying we can revisit.