search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.21k stars 515 forks source link

There is no "+ Create new registry..." in "Select registry" option #4086

Closed v-ruizh closed 11 months ago

v-ruizh commented 1 year ago

OS: Win 10 Build Version: 20230922.1 Regression: Previous Release

Repro Steps:

  1. Connect Azure registry.
  2. Navigate to Image view -> Right click one image and select "Push..." action -> Select "Azure" -> Select a subscription.
  3. Check whether there is a "+ Create new registry..." in "Select registry" option.

Expect: There is a "+ Create new registry..." in "Select registry" option. image

Actual: There is no "+ Create new registry..." in "Select registry" option. image

More Info: This issue does not reproduce on the current released Docker extension v1.26.1.

alexyaang commented 1 year ago

This is something we could add back but it may take a little bit of work. @bwateratmsft thoughts?

bwateratmsft commented 1 year ago

@alexweininger where did we land on create picks?

bwateratmsft commented 11 months ago

I think Push is a special command that uniquely deserves to have the ACR create pick. I'm wondering if it wouldn't be best to just refactor the whole Push command to be an AzureWizard, and forego using the URTDP to pick the registry, instead going to the backing data.