search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.21k stars 515 forks source link

[Suggestion] It would be better to add a prompt "No matching resources found" when no registry can be connected #4087

Closed v-ruizh closed 1 year ago

v-ruizh commented 1 year ago

OS: Win 10 Build Version: 20230922.1

Repro Steps:

  1. Connect all registries (Azure/Docker Hub/GitHub/Generic Registry V2) in REGISTRIES view.
  2. Click "Connect Registry..." button again.
  3. Check whether there is a prompt "No matching resources found" or not.

Actual: There is no prompt, it keeps in "Select a registry provider to use" step. image

Suggestion: It would be better to add a prompt "No matching resources found" when no registry can be connected.

alexyaang commented 1 year ago

I like the suggestion. We can add something like this when there's 0 things present. @bwateratmsft, how do you feel?

bwateratmsft commented 1 year ago

Agreed, should be easy to add an error or something like that.