search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.21k stars 515 forks source link

There is no validation for the existing URL when connecting to generic Docker registry #4091

Closed v-ruizh closed 1 year ago

v-ruizh commented 1 year ago

OS: All Build Version: 20230923.1 Regression: Previous Release

Repro Steps:

  1. Connect "Generic Registry V2" registry with URL "http://localhost:5100".
  2. Right click "Generic Registry V2" registry -> Select "Connect to Generic Docker Registry..." -> Enter the above URL again.
  3. Check whether there is a validation for the existing URL.

Expect: There is a validation for the existing URL. image

Actual: There is no validation for the existing URL. image

More Info:

  1. The existing RUL can be connected again without any error, 2 same registries show in the "Registries" view. image
  2. This issue does not reproduce on the current released Docker extension v1.26.1.
alexyaang commented 1 year ago

This is okay with me since the user is adding duplicate registries but it is a nice to have. Does something like test/:5050 validate?

bwateratmsft commented 1 year ago

Let's see if it's complicated to add this. If it's just a few lines then I'm cool with adding it but if it's complex then I think we can won't-fix.

alexyaang commented 1 year ago

Yeah sounds good!