search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.21k stars 515 forks source link

There is no "Learn more" button in the notification when deleting image from one generic Docker registry #4092

Closed v-ruizh closed 1 year ago

v-ruizh commented 1 year ago

OS: All Build Version: 20230923.1 Regression: Previous Release

Repro Steps:

  1. Connect "Generic Registry V2" registry with URL "http://localhost:5100".
  2. Push one image to the above registry.
  3. Expand the above registry -> Right click the image and execute "Delete Image..." action.
  4. Check whether there is a "Learn more" button in the notification.

Expect: There is a "Learn more" button in the notification, like it in the current released extension v1.26.1. image

Actual: There is no "Learn more" button in the notification. image

More Info: This notification is different from the one in the current released extension v1.26.1.

alexyaang commented 1 year ago

I'll need to investigate into this one.

alexyaang commented 1 year ago

So it seems like parseError() is not working properly. I think the current message is still informative, maybe not as informative as the old message. To make this work, we'll need to implement a custom error parser. @bwateratmsft do you think it's worth the time?