search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.21k stars 515 forks source link

There is no prompt "No matching resources found" when executing "Docker Registries: Disconnect" command from command palette #4099

Closed v-chenzha closed 1 year ago

v-chenzha commented 1 year ago

OS: All Build Version: 20230926.1 Regression: Previous Release

Repro Steps:

  1. Disconnect all registries (Azure/Docker Hub/GitHub/Generic Registry V2) in REGISTRIES view.
  2. F1 -> Docker Registries: Disconnect.
  3. Check whether there is a prompt "No matching resources found" or not.

Expect: There is a prompt "No matching resources found". image

Actual: There is "Connect Registry..." command. image

alexyaang commented 1 year ago

I actually like the current behavior more. @bwateratmsft what do you think?

bwateratmsft commented 1 year ago

It doesn't really make sense to offer a "Connect registry" option when you're in the process of disconnecting

alexyaang commented 1 year ago

ehhh yeah that is true, i'll remove it

alexyaang commented 1 year ago

image

Would this be okay when you run Docker Registries: Disconnect. when no registries are connected?

bwateratmsft commented 1 year ago

I think it's fine--not perfect but not a big deal.