search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.21k stars 515 forks source link

There is no error in "Docker Hub" registry if connecting it with incorrect username and password at the second time #4102

Closed v-ruizh closed 1 year ago

v-ruizh commented 1 year ago

OS: All Build Version: 20230926.1 Regression: Previous Release

Repro Steps:

  1. Connect "Docker Hub" registry with correct username and password.
  2. Disconnect the above "Docker Hub" registry.
  3. Connect "Docker Hub" registry again with incorrect username and password.
  4. Check whether there is an error in "Docker Hub" registry.

Expect: There is an error in "Docker Hub" registry. image

Actual: There is no error in "Docker Hub" registry. image

More Info:

  1. Refresh the "Registries" view can't fix this issue.
  2. The error shows well after reloading VS Code window.
  3. This issue does not reproduce on the current released Docker extension v1.26.1.
bwateratmsft commented 1 year ago

I think this is because the Docker Hub auth provider gets the token and then uses it for the rest of the session.

bwateratmsft commented 1 year ago

@alexyaang tested and if you go in the other direction--wrong password, disconnect, right password--things work as they should. Since this is far more likely we'll won't-fix this one.