search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.19k stars 508 forks source link

An error occurs after expanding the Azure registry #4141

Closed v-xinda closed 7 months ago

v-xinda commented 8 months ago

OS: All Build Version: 1.27.0

Repro Steps:

  1. Connect Azure registry -> Expand it.
  2. Check whether no error occurs.

Expect: No error occurs.

Actual: An error occurs.

Screenshot 2023-10-26 at 10 13 25
bwateratmsft commented 8 months ago

I have seen this too but I did not notice any negative effects. @TylerLeonhardt is this a known issue?

bwateratmsft commented 8 months ago

It looks like this might be due to https://github.com/microsoft/vscode-azuretools/issues/1607 which just requires an update of the azureauth package.

v-xinda commented 8 months ago

This issue still reproduces for now with the build 20231107.2.

bwateratmsft commented 8 months ago

I haven't seen this since the update. @v-xinda, can you email me the output from the Output window, "Microsoft Authentication" tab when the error occurs? Please email it as it may contain PII.

image

bwateratmsft commented 8 months ago

I suspect this issue may still occur even after it's been fixed in the Docker extension, but if you don't encounter it to begin with, you never will. Essentially, the authentication provider is getting stuck with a bad session and it seems unable to actually log out of it, so the error keeps coming up, but the Docker extension is no longer requesting bad sessions.

bwateratmsft commented 8 months ago

In short, it won't be an issue for external users if my suspicion is right.

bwateratmsft commented 7 months ago

Based on offline conversation I think my hunch is right; the bad data left over from before the fix caused the issue to reoccur once, but never again. External customers should not run into this.